1 | |
2 | |
3 | |
4 | |
5 | |
6 | |
7 | |
8 | |
9 | |
10 | |
11 | |
12 | |
13 | |
14 | #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h" |
15 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
16 | #include "clang/StaticAnalyzer/Core/Checker.h" |
17 | #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h" |
18 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
19 | #include "llvm/ADT/FoldingSet.h" |
20 | |
21 | using namespace clang; |
22 | using namespace ento; |
23 | |
24 | namespace { |
25 | |
26 | class ZeroState { |
27 | private: |
28 | SymbolRef ZeroSymbol; |
29 | unsigned BlockID; |
30 | const StackFrameContext *SFC; |
31 | |
32 | public: |
33 | ZeroState(SymbolRef S, unsigned B, const StackFrameContext *SFC) |
34 | : ZeroSymbol(S), BlockID(B), SFC(SFC) {} |
35 | |
36 | const StackFrameContext *getStackFrameContext() const { return SFC; } |
37 | |
38 | bool operator==(const ZeroState &X) const { |
39 | return BlockID == X.BlockID && SFC == X.SFC && ZeroSymbol == X.ZeroSymbol; |
40 | } |
41 | |
42 | bool operator<(const ZeroState &X) const { |
43 | if (BlockID != X.BlockID) |
44 | return BlockID < X.BlockID; |
45 | if (SFC != X.SFC) |
46 | return SFC < X.SFC; |
47 | return ZeroSymbol < X.ZeroSymbol; |
48 | } |
49 | |
50 | void Profile(llvm::FoldingSetNodeID &ID) const { |
51 | ID.AddInteger(BlockID); |
52 | ID.AddPointer(SFC); |
53 | ID.AddPointer(ZeroSymbol); |
54 | } |
55 | }; |
56 | |
57 | class DivisionBRVisitor : public BugReporterVisitor { |
58 | private: |
59 | SymbolRef ZeroSymbol; |
60 | const StackFrameContext *SFC; |
61 | bool Satisfied; |
62 | |
63 | public: |
64 | DivisionBRVisitor(SymbolRef ZeroSymbol, const StackFrameContext *SFC) |
65 | : ZeroSymbol(ZeroSymbol), SFC(SFC), Satisfied(false) {} |
66 | |
67 | void Profile(llvm::FoldingSetNodeID &ID) const override { |
68 | ID.Add(ZeroSymbol); |
69 | ID.Add(SFC); |
70 | } |
71 | |
72 | std::shared_ptr<PathDiagnosticPiece> VisitNode(const ExplodedNode *Succ, |
73 | BugReporterContext &BRC, |
74 | BugReport &BR) override; |
75 | }; |
76 | |
77 | class TestAfterDivZeroChecker |
78 | : public Checker<check::PreStmt<BinaryOperator>, check::BranchCondition, |
79 | check::EndFunction> { |
80 | mutable std::unique_ptr<BuiltinBug> DivZeroBug; |
81 | void reportBug(SVal Val, CheckerContext &C) const; |
82 | |
83 | public: |
84 | void checkPreStmt(const BinaryOperator *B, CheckerContext &C) const; |
85 | void checkBranchCondition(const Stmt *Condition, CheckerContext &C) const; |
86 | void checkEndFunction(const ReturnStmt *RS, CheckerContext &C) const; |
87 | void setDivZeroMap(SVal Var, CheckerContext &C) const; |
88 | bool hasDivZeroMap(SVal Var, const CheckerContext &C) const; |
89 | bool isZero(SVal S, CheckerContext &C) const; |
90 | }; |
91 | } |
92 | |
93 | REGISTER_SET_WITH_PROGRAMSTATE(DivZeroMap, ZeroState) |
94 | |
95 | std::shared_ptr<PathDiagnosticPiece> |
96 | DivisionBRVisitor::VisitNode(const ExplodedNode *Succ, |
97 | BugReporterContext &BRC, BugReport &BR) { |
98 | if (Satisfied) |
99 | return nullptr; |
100 | |
101 | const Expr *E = nullptr; |
102 | |
103 | if (Optional<PostStmt> P = Succ->getLocationAs<PostStmt>()) |
104 | if (const BinaryOperator *BO = P->getStmtAs<BinaryOperator>()) { |
105 | BinaryOperator::Opcode Op = BO->getOpcode(); |
106 | if (Op == BO_Div || Op == BO_Rem || Op == BO_DivAssign || |
107 | Op == BO_RemAssign) { |
108 | E = BO->getRHS(); |
109 | } |
110 | } |
111 | |
112 | if (!E) |
113 | return nullptr; |
114 | |
115 | SVal S = Succ->getSVal(E); |
116 | if (ZeroSymbol == S.getAsSymbol() && SFC == Succ->getStackFrame()) { |
117 | Satisfied = true; |
118 | |
119 | |
120 | ProgramPoint P = Succ->getLocation(); |
121 | PathDiagnosticLocation L = |
122 | PathDiagnosticLocation::create(P, BRC.getSourceManager()); |
123 | |
124 | if (!L.isValid() || !L.asLocation().isValid()) |
125 | return nullptr; |
126 | |
127 | return std::make_shared<PathDiagnosticEventPiece>( |
128 | L, "Division with compared value made here"); |
129 | } |
130 | |
131 | return nullptr; |
132 | } |
133 | |
134 | bool TestAfterDivZeroChecker::isZero(SVal S, CheckerContext &C) const { |
135 | Optional<DefinedSVal> DSV = S.getAs<DefinedSVal>(); |
136 | |
137 | if (!DSV) |
138 | return false; |
139 | |
140 | ConstraintManager &CM = C.getConstraintManager(); |
141 | return !CM.assume(C.getState(), *DSV, true); |
142 | } |
143 | |
144 | void TestAfterDivZeroChecker::setDivZeroMap(SVal Var, CheckerContext &C) const { |
145 | SymbolRef SR = Var.getAsSymbol(); |
146 | if (!SR) |
147 | return; |
148 | |
149 | ProgramStateRef State = C.getState(); |
150 | State = |
151 | State->add<DivZeroMap>(ZeroState(SR, C.getBlockID(), C.getStackFrame())); |
152 | C.addTransition(State); |
153 | } |
154 | |
155 | bool TestAfterDivZeroChecker::hasDivZeroMap(SVal Var, |
156 | const CheckerContext &C) const { |
157 | SymbolRef SR = Var.getAsSymbol(); |
158 | if (!SR) |
159 | return false; |
160 | |
161 | ZeroState ZS(SR, C.getBlockID(), C.getStackFrame()); |
162 | return C.getState()->contains<DivZeroMap>(ZS); |
163 | } |
164 | |
165 | void TestAfterDivZeroChecker::reportBug(SVal Val, CheckerContext &C) const { |
166 | if (ExplodedNode *N = C.generateErrorNode(C.getState())) { |
167 | if (!DivZeroBug) |
168 | DivZeroBug.reset(new BuiltinBug(this, "Division by zero")); |
169 | |
170 | auto R = llvm::make_unique<BugReport>( |
171 | *DivZeroBug, "Value being compared against zero has already been used " |
172 | "for division", |
173 | N); |
174 | |
175 | R->addVisitor(llvm::make_unique<DivisionBRVisitor>(Val.getAsSymbol(), |
176 | C.getStackFrame())); |
177 | C.emitReport(std::move(R)); |
178 | } |
179 | } |
180 | |
181 | void TestAfterDivZeroChecker::checkEndFunction(const ReturnStmt *, |
182 | CheckerContext &C) const { |
183 | ProgramStateRef State = C.getState(); |
184 | |
185 | DivZeroMapTy DivZeroes = State->get<DivZeroMap>(); |
186 | if (DivZeroes.isEmpty()) |
187 | return; |
188 | |
189 | DivZeroMapTy::Factory &F = State->get_context<DivZeroMap>(); |
190 | for (llvm::ImmutableSet<ZeroState>::iterator I = DivZeroes.begin(), |
191 | E = DivZeroes.end(); |
192 | I != E; ++I) { |
193 | ZeroState ZS = *I; |
194 | if (ZS.getStackFrameContext() == C.getStackFrame()) |
195 | DivZeroes = F.remove(DivZeroes, ZS); |
196 | } |
197 | C.addTransition(State->set<DivZeroMap>(DivZeroes)); |
198 | } |
199 | |
200 | void TestAfterDivZeroChecker::checkPreStmt(const BinaryOperator *B, |
201 | CheckerContext &C) const { |
202 | BinaryOperator::Opcode Op = B->getOpcode(); |
203 | if (Op == BO_Div || Op == BO_Rem || Op == BO_DivAssign || |
204 | Op == BO_RemAssign) { |
205 | SVal S = C.getSVal(B->getRHS()); |
206 | |
207 | if (!isZero(S, C)) |
208 | setDivZeroMap(S, C); |
209 | } |
210 | } |
211 | |
212 | void TestAfterDivZeroChecker::checkBranchCondition(const Stmt *Condition, |
213 | CheckerContext &C) const { |
214 | if (const BinaryOperator *B = dyn_cast<BinaryOperator>(Condition)) { |
215 | if (B->isComparisonOp()) { |
216 | const IntegerLiteral *IntLiteral = dyn_cast<IntegerLiteral>(B->getRHS()); |
217 | bool LRHS = true; |
218 | if (!IntLiteral) { |
219 | IntLiteral = dyn_cast<IntegerLiteral>(B->getLHS()); |
220 | LRHS = false; |
221 | } |
222 | |
223 | if (!IntLiteral || IntLiteral->getValue() != 0) |
224 | return; |
225 | |
226 | SVal Val = C.getSVal(LRHS ? B->getLHS() : B->getRHS()); |
227 | if (hasDivZeroMap(Val, C)) |
228 | reportBug(Val, C); |
229 | } |
230 | } else if (const UnaryOperator *U = dyn_cast<UnaryOperator>(Condition)) { |
231 | if (U->getOpcode() == UO_LNot) { |
232 | SVal Val; |
233 | if (const ImplicitCastExpr *I = |
234 | dyn_cast<ImplicitCastExpr>(U->getSubExpr())) |
235 | Val = C.getSVal(I->getSubExpr()); |
236 | |
237 | if (hasDivZeroMap(Val, C)) |
238 | reportBug(Val, C); |
239 | else { |
240 | Val = C.getSVal(U->getSubExpr()); |
241 | if (hasDivZeroMap(Val, C)) |
242 | reportBug(Val, C); |
243 | } |
244 | } |
245 | } else if (const ImplicitCastExpr *IE = |
246 | dyn_cast<ImplicitCastExpr>(Condition)) { |
247 | SVal Val = C.getSVal(IE->getSubExpr()); |
248 | |
249 | if (hasDivZeroMap(Val, C)) |
250 | reportBug(Val, C); |
251 | else { |
252 | SVal Val = C.getSVal(Condition); |
253 | |
254 | if (hasDivZeroMap(Val, C)) |
255 | reportBug(Val, C); |
256 | } |
257 | } |
258 | } |
259 | |
260 | void ento::registerTestAfterDivZeroChecker(CheckerManager &mgr) { |
261 | mgr.registerChecker<TestAfterDivZeroChecker>(); |
262 | } |
263 | |
264 | bool ento::shouldRegisterTestAfterDivZeroChecker(const LangOptions &LO) { |
265 | return true; |
266 | } |
267 | |